Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid explicit np.nan, np.inf #383

Merged
merged 3 commits into from
Aug 14, 2024
Merged

Avoid explicit np.nan, np.inf #383

merged 3 commits into from
Aug 14, 2024

Conversation

dcherian
Copy link
Collaborator

@dcherian dcherian commented Aug 7, 2024

Extracted from #374

  • Needs some property tests.

@dcherian dcherian changed the title Handle dtypes.NA properly for datetime/timedelta Avoid explicit np.nan, np.inf Aug 7, 2024
@dcherian dcherian marked this pull request as ready for review August 7, 2024 15:43
@dcherian
Copy link
Collaborator Author

I think the benchmark is/was broken on main.

@dcherian dcherian merged commit 4dbadae into main Aug 14, 2024
14 of 15 checks passed
@dcherian dcherian deleted the cleanups branch August 14, 2024 04:16
dcherian added a commit that referenced this pull request Jan 7, 2025
* main:
  Revert "Support first, last with datetime, timedelta (#402)" (#404)
  Support first, last with datetime, timedelta (#402)
  Bump codecov/codecov-action from 4.5.0 to 4.6.0 (#401)
  Bump mamba-org/setup-micromamba from 1 to 2 (#400)
  Revert "[revert] test with Xarray PR branch" (#393)
  [pre-commit.ci] pre-commit autoupdate (#399)
  Faster subsetting for cohorts (#397)
  Fix default int on windows, numpy<2 (#395)
  Avoid rechunking when preferred_method="blockwise" (#394)
  Preserve dtype better when specified. (#389)
  Drop python 3.9, use ruff (#392)
  silence warning (#390)
  Expand groupby_reduce property tests (#385)
  Fix bug with NaNs in `by` and method='blockwise' (#384)
  Avoid explicit np.nan, np.inf (#383)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant